DevHeads.net

Postings by sobak

com web/windows: Generate news dates using helper function for both ease and correctness: docroot/index.php

Link: <a href="http://git.php.net/?p=web/windows.git;a=commitdiff;h=4f6dee33a590661528ee6daedf7d4ee1038422f5" title="http://git.php.net/?p=web/windows.git;a=commitdiff;h=4f6dee33a590661528ee6daedf7d4ee1038422f5">http://git.php.net/?p=web/windows.git;a=commitdiff;h=4f6dee33a590661528e...</a>

Log:
Generate news dates using helper function for both ease and correctness

Changed paths:
M docroot/index.php

com web/windows: Further simplification of footer: docroot/styles/content.css templates/footer.php

Link: <a href="http://git.php.net/?p=web/windows.git;a=commitdiff;h=b78ec783878ce62bd7c0971f29cd36f5ce6e6051" title="http://git.php.net/?p=web/windows.git;a=commitdiff;h=b78ec783878ce62bd7c0971f29cd36f5ce6e6051">http://git.php.net/?p=web/windows.git;a=commitdiff;h=b78ec783878ce62bd7c...</a>

Log:
Further simplification of footer

Changed paths:
M docroot/styles/content.css
M templates/footer.php

Diff:
diff --git a/docroot/styles/content.css b/docroot/styles/content.css
index dd1422b..2b41c24 100644
--- a/docroot/styles/content.css
+++ b/docroot/styles/content.css
@@ -774,43 +774,8 @@

#footer .info {
line-height:1.4;
- padding:18px 12px;
-}

Request for web-windows karma

Hi folks,

I'd like to request karma for web-windows repository.

com web/people: Fix typo: include/karma.php

Link: <a href="http://git.php.net/?p=web/people.git;a=commitdiff;h=5f6b373c74b786774310b255148c5a57ef1ca771" title="http://git.php.net/?p=web/people.git;a=commitdiff;h=5f6b373c74b786774310b255148c5a57ef1ca771">http://git.php.net/?p=web/people.git;a=commitdiff;h=5f6b373c74b786774310...</a>

Log:
Fix typo

Changed paths:
M include/karma.php

Diff:
diff --git a/include/karma.php b/include/karma.php
index 63bf290..8ade67c 100644
--- a/include/karma.php
+++ b/include/karma.php
@@ -143,7 +143,7 @@ function formatKarmaLinks($line)
// PHP Group members, such as Rasmus, got access to everything.

com web/bugs: Simplify the code around bug.php?edit=(1|2) (developer/edit): www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=65324db638c8667c0326634b14dcccabdb3cc404" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=65324db638c8667c0326634b14dcccabdb3cc404">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=65324db638c8667c032663...</a>

Log:
Simplify the code around bug.php?edit=(1|2) (developer/edit)

Sorry for the additional diff to review but this part of code was
terribly hard to follow.

com web/bugs: Simplify the code around bug.php?edit=(1|2) (developer/edit): www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=f83d899a922208c2b5355e06176059383342e0e1" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=f83d899a922208c2b5355e06176059383342e0e1">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=f83d899a922208c2b5355e...</a>

Log:
Simplify the code around bug.php?edit=(1|2) (developer/edit)

Sorry for the additional diff to review but this part of code was
terribly hard to follow.

com web/bugs: bug.php - thanks messages: include/functions.php www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=79d0754201fb88e50048d60923bdcb249cc6ed58" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=79d0754201fb88e50048d60923bdcb249cc6ed58">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=79d0754201fb88e50048d6...</a>

Log:
bug.php - thanks messages

Changed paths:
M include/functions.php
M www/bug.php

Diff:
diff --git a/include/functions.php b/include/functions.php
index c1fc408..0e01ede 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -1697,7 +1697,7 @@ function bugs_mail($to, $subject, $message, $headers = '', $params = '')
* @param string $title a string to go into the header's <title>
* @return void
*/
-function response_header($title, $extraHeaders = '')
+function respo

com web/bugs: Rework bug.php?edit=3 (adding new comment): www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d7aecd6490d6045f8e9fda943c99dd7701c88b45" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d7aecd6490d6045f8e9fda943c99dd7701c88b45">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d7aecd6490d6045f8e9fda...</a>

Log:
Rework bug.php?edit=3 (adding new comment)

Changed paths:
M www/bug.php

Diff:
diff --git a/www/bug.php b/www/bug.php
index ca2143e..060b043 100644
--- a/www/bug.php
+++ b/www/bug.php
@@ -723,19 +723,8 @@ if ($bug_id !== 'PREVIEW') {

} // if ($bug_id != 'PREVIEW') { 

-//
-// FIXME! Do not wrap here either. Re-use the comment display function!
-//

com web/bugs: More improvements for output_note(): www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=b624b944eb82819d3bcf086ff52b872005a86161" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=b624b944eb82819d3bcf086ff52b872005a86161">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=b624b944eb82819d3bcf08...</a>

Log:
More improvements for output_note()

Changed paths:
M www/bug.php

Diff:
diff --git a/www/bug.php b/www/bug.php
index 95f71b8..ca2143e 100644
--- a/www/bug.php
+++ b/www/bug.php
@@ -1144,7 +1144,7 @@ function is_php_user($email)

function output_note($com_id, $ts, $email, $comment, $comment_name, $comment_type = null)
{
- global $edit, $bug_id, $dbh, $is_trusted_developer, $logged_in;
+ global $edit, $bug_id, $is_trusted_developer;

// $com_id = 0 means the bug report itself i

com web/bugs: Redesign single bug page - first round: www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=98cd587a46190080649f8cca57036d65592f2a91" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=98cd587a46190080649f8cca57036d65592f2a91">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=98cd587a46190080649f8c...</a>

Log:
Redesign single bug page - first round

Changed paths:
M www/bug.php

com web/bugs: Add missing page header: www/search.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d43ff33ce1fce828c8bc824b1400b2c3789cc494" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d43ff33ce1fce828c8bc824b1400b2c3789cc494">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=d43ff33ce1fce828c8bc82...</a>

Log:
Add missing page header

Changed paths:
M www/search.php

Diff:
diff --git a/www/search.php b/www/search.php
index 35ad808..370610a 100644
--- a/www/search.php
+++ b/www/search.php
@@ -111,6 +111,7 @@ if (isset($_GET['cmd']) && $_GET['cmd'] == 'display')
$link .= '&amp;status=' . urlencode($status);
$package_count = count($package_name);
?>
+<h1>Search results</h1>

<table border="0" class="standard search-bugs">

com web/bugs: Datetimes are still GMT/UTC but let's state that only once, in the footer: include/functions.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8c4fe03924f2bdaa1ba649b52100f0fb360f9369" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8c4fe03924f2bdaa1ba649b52100f0fb360f9369">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8c4fe03924f2bdaa1ba649...</a>

Log:
Datetimes are still GMT/UTC but let's state that only once, in the footer

Changed paths:
M include/functions.php

Diff:
diff --git a/include/functions.php b/include/functions.php
index 60dff67..c1fc408 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -1140,7 +1140,7 @@ DEV_TEXT;
*
* @return string the formatted date
*/
-function format_date($ts = null, $format = 'Y-m-d H:i e')
+function format_date($ts = null, $format = 'Y-m-d H:i')
{
if (!$ts) {
$ts =

com web/bugs: Rework search results: www/search.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=ef6bf3c92a2858c4c87575e5b0ccaf0fe689e9a5" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=ef6bf3c92a2858c4c87575e5b0ccaf0fe689e9a5">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=ef6bf3c92a2858c4c87575...</a>

Log:
Rework search results

Changed paths:
M www/search.php

Diff:
diff --git a/www/search.php b/www/search.php
index 727c41c..35ad808 100644
--- a/www/search.php
+++ b/www/search.php
@@ -112,53 +112,51 @@ if (isset($_GET['cmd']) && $_GET['cmd'] == 'display')
$package_count = count($package_name);
?>

-<table border="0" cellspacing="2" width="100%">
+<table border="0" class="standard search-bugs">

<?php show_prev_next($begin, $rows, $total_rows, $link, $limit);?>

<?php if ($p

com web/bugs: Shorten message so it fits in one line on most screen sizes: www/report.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8cec04889c851558a9052d7d01a3aff3a9eaedd8" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8cec04889c851558a9052d7d01a3aff3a9eaedd8">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8cec04889c851558a9052d...</a>

Log:
Shorten message so it fits in one line on most screen sizes

Changed paths:
M www/report.php

Diff:
diff --git a/www/report.php b/www/report.php
index 5ea2308..8c043d8 100644
--- a/www/report.php
+++ b/www/report.php
@@ -362,9 +362,9 @@ if (!isset($_POST['in'])) {
</p>

com web/bugs: Fix quick searches on the main page: www/index.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=911855d305c336cc7d6d7d639d65bbb661f1887a" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=911855d305c336cc7d6d7d639d65bbb661f1887a">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=911855d305c336cc7d6d7d...</a>

Log:
Fix quick searches on the main page

Changed paths:
M www/index.php

Diff:
diff --git a/www/index.php b/www/index.php
index 7373c80..1ac31b9 100644
--- a/www/index.php
+++ b/www/index.php
@@ -112,7 +112,7 @@ how search works.</p>

com web/bugs: Minor adjustments for simpler pages like "How to report" or "Search howto": www/assets/css/style.css www/assets/images/backtrace-images-win32/analyze.jpg www/assets/images/backtrace-images-win32/backtrace.jpg www/assets/image

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=38eb30b7ca8c7ac13d3ba9606266ef9500dac2bc" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=38eb30b7ca8c7ac13d3ba9606266ef9500dac2bc">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=38eb30b7ca8c7ac13d3ba9...</a>

Log:
Minor adjustments for simpler pages like "How to report" or "Search howto"

Changed paths:
M www/assets/css/style.css
A www/assets/images/backtrace-images-win32/analyze.jpg
A www/assets/images/backtrace-images-win32/backtrace.jpg
A www/assets/images/backtrace-images-win32/dbg_options.png
A www/assets/images/backtrace-images-win32/dbg_select_php.png
A www/assets/images/backtrace-images-win32/dbg_wizard_1.png
A www/assets/images/backtrace-images-win32/dbg_wizard_2.png

com web/bugs: Drop no longer used files: templates/patchform.php www/images/pear_item.gif www/images/pecl_item.gif

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0a834ca90dfd2bb864ccf8c6d704cb4c830c4d50" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0a834ca90dfd2bb864ccf8c6d704cb4c830c4d50">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0a834ca90dfd2bb864ccf8...</a>

Log:
Drop no longer used files

Changed paths:
D templates/patchform.php
D www/images/pear_item.gif
D www/images/pecl_item.gif

Diff:
diff --git a/templates/patchform.php b/templates/patchform.php
deleted file mode 100644
index a930494..0000000
--- a/templates/patchform.php
+++ /dev/null
@@ -1,22 +0,0 @@
- <tr>
- <th class="form-label_left">
- Patch name
- </th>
- <td class="form-input">
- <p class="cell_note">
- The patch name must be shorter than 80 characters and it mu

com web/bugs: First shot on reporting new bug: include/functions.php www/report.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=3189900a537551e141cf78f329e857d4db138884" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=3189900a537551e141cf78f329e857d4db138884">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=3189900a537551e141cf78...</a>

Log:
First shot on reporting new bug

Changed paths:
M include/functions.php
M www/report.php

com web/bugs: Redesign main page: www/index.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=07291d07cb8c6fd633a5cce458b20f61a0d4531f" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=07291d07cb8c6fd633a5cce458b20f61a0d4531f">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=07291d07cb8c6fd633a5cc...</a>

Log:
Redesign main page

Changed paths:
M www/index.php

Diff:
diff --git a/www/index.php b/www/index.php
index dc00fb7..7373c80 100644
--- a/www/index.php
+++ b/www/index.php
@@ -35,17 +35,16 @@ if (bugid > 0) {

<h1>PHP Bug Tracking System</h1>

-<p>Before you report a bug, please make sure you have completed the following steps:</p>
+<p>Before you report a bug, please make sure you:</p>

com web/bugs: Switch to new design - the beginning: include/functions.php www/assets/css/chosen.css www/assets/css/fonts.css www/assets/css/style.css www/assets/fonts/Fira/eot/FiraMono-Bold.eot www/assets/fonts/Fira/eot/FiraMono-Regular.eo

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=34e5593b9d81bfea3e02f8e89c5d24435ea23d87" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=34e5593b9d81bfea3e02f8e89c5d24435ea23d87">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=34e5593b9d81bfea3e02f8...</a>

Log:
Switch to new design - the beginning

Just upload new styles and other assets for now, and change markup
for the header and footer.

Changed paths:
M include/functions.php
A www/assets/css/chosen.css
A www/assets/css/fonts.css
A www/assets/css/style.css
A www/assets/fonts/Fira/eot/FiraMono-Bold.eot
A www/assets/fonts/Fira/eot/FiraMono-Regular.eot
A www/assets/fonts/Fira/eot/FiraSans-Book.eot
A www/assets/fonts/Fira/eot/FiraSans-BookItalic.eot
A www/assets/font

Redesign of bugs.php.net

Hello,

I know it's bringing the same thread again but since my last post[1]
I gathered some feedback on /r/php, including a few membmers of PHP.net.

<a href="https://github.com/Sobak/bugsnet-redesign-mockup" title="https://github.com/Sobak/bugsnet-redesign-mockup">https://github.com/Sobak/bugsnet-redesign-mockup</a> this is the repo for
my experimental approach on redesigning PHP.net. Short story: I took the
design of php.net main website and after some modifications used it for
our bugtracker.

Long story? All details are in the repo's README file.

WIP bugs.php.net migration to PDO - request for comments on the approach

Hi,

perhaps some of you might be interested in
<a href="https://github.com/php/web-bugs/pull/26" title="https://github.com/php/web-bugs/pull/26">https://github.com/php/web-bugs/pull/26</a> (it seems PR notifications
doesn't work for this repo).

Could I have your input, please? I'd love this migration to happen so
that after removing dependency on PEAR_HTTP_Upload bugs.php.net could
run on PHP7 flawlessly (in fact, even PHP 5.4 errors now unless alpha
version of MDB2 [from 2012...] is used).

Have a good day!
Maciej

com web/bugs: Add missing returns for the fix from previous commit: include/functions.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=df52d48b164c816305ddc50e88ae757b1770970b" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=df52d48b164c816305ddc50e88ae757b1770970b">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=df52d48b164c816305ddc5...</a>

Log:
Add missing returns for the fix from previous commit

It accidentally worked as php_versions.php fetched versions anyway if
apc_fetch() returned falsy value, but this is correct version.

Changed paths:
M include/functions.php

Diff:
diff --git a/include/functions.php b/include/functions.php
index b132633..a2db0dc 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -1957,12 +1957,12 @@ function mailto_list(array $mails)

if (!function_exists('apc_fetch')) {
functio

com web/bugs: Allow to run on PHP 7 (fix missing apc_* functions): include/functions.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0db9df83c9683ffa4358b56fe1f2962ce5704a12" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0db9df83c9683ffa4358b56fe1f2962ce5704a12">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0db9df83c9683ffa4358b5...</a>

Log:
Allow to run on PHP 7 (fix missing apc_* functions)

Only ext/apcu is available on PHP7.

com web/bugs: Remove dependency on PEAR_HTTP: README.md www/patch-display.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=30f26dbf6e22e25ea7c22feeed2b9797abd77a47" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=30f26dbf6e22e25ea7c22feeed2b9797abd77a47">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=30f26dbf6e22e25ea7c22f...</a>

Log:
Remove dependency on PEAR_HTTP

Changed paths:
M README.md
M www/patch-display.php

Diff:
diff --git a/README.md b/README.md
index 7bf2d07..125c1a1 100644
--- a/README.md
+++ b/README.md
@@ -13,14 +13,13 @@ Requirements
- DB_DataObject
- Text_CAPTCHA_Numeral
- Text_Diff
- - HTTP
- HTTP_Upload

Installation
============
1. Copy `local_config.php.sample` to `local_config.php` and modify accordingly
2.

bugs.php.net redesign proposal - mockup inside

Hi!

To specify: a mockup from person unable to came up with new shiny idea
and lacking special design skills.

Your ideas for bugs.php.net improvements

Hello guys,

while discussing possible ways to reduce number of open bug reports[1]
many people expressed their (valid, I think) complaints about our
bugtracker itself.

Could we keep those discussions separated? I just created new wiki page
<a href="https://wiki.php.net/ideas/bugtracker" title="https://wiki.php.net/ideas/bugtracker">https://wiki.php.net/ideas/bugtracker</a> gathering some common ideas on
the matter.

I suggest to treat this thread like an open wishlist. I know there is a
log way between an idea and its implementation but we certainly need to
start somehow. Little discussion doesn't seem to do any harm.

Feel free to reply here and/or update wiki page.

com web/master: Allow to search notes within a specfified section: include/functions.inc manage/user-notes.php

Link: <a href="http://git.php.net/?p=web/master.git;a=commitdiff;h=ed329ef22c59228b5736cf2750283fedf87f733a" title="http://git.php.net/?p=web/master.git;a=commitdiff;h=ed329ef22c59228b5736cf2750283fedf87f733a">http://git.php.net/?p=web/master.git;a=commitdiff;h=ed329ef22c59228b5736...</a>

Log:
Allow to search notes within a specfified section

Changed paths:
M include/functions.inc
M manage/user-notes.php

Diff:
diff --git a/include/functions.inc b/include/functions.inc
index dfac701..ce915a1 100644
--- a/include/functions.inc
+++ b/include/functions.inc
@@ -40,7 +40,7 @@ function head($title="", $config = array()) {
$SEARCH = array("method" => "get", "action" => "/manage/event.php", "placeholder" => "Search Events", "name" => "search");
}
if (strs

com web/master: Only show link if user can use it: manage/user-notes.php

Link: <a href="http://git.php.net/?p=web/master.git;a=commitdiff;h=48fd4fb67a5224060ff0cb6c17e7273598496d93" title="http://git.php.net/?p=web/master.git;a=commitdiff;h=48fd4fb67a5224060ff0cb6c17e7273598496d93">http://git.php.net/?p=web/master.git;a=commitdiff;h=48fd4fb67a5224060ff0...</a>

Log:
Only show link if user can use it

Changed paths:
M manage/user-notes.php

Diff:
diff --git a/manage/user-notes.php b/manage/user-notes.php
index 01f497a..e77e465 100644
--- a/manage/user-notes.php
+++ b/manage/user-notes.php
@@ -429,7 +429,7 @@ if (!$action) {
?>

<h2>Menu</h2>
-<p><a href="<?= PHP_SELF ?>?action=mass">Mass change of sections</a></p>
+<?php if (allow_mass_change($cuser)): ?><p><a href="<?= PHP_SELF ?>?action=mass">Mass change of sections</a></p>

com web/master: Paginate note search results instead of showing last 20: manage/user-notes.php

Link: <a href="http://git.php.net/?p=web/master.git;a=commitdiff;h=ab707a8a058e70f93419c046283a11c0a21135e8" title="http://git.php.net/?p=web/master.git;a=commitdiff;h=ab707a8a058e70f93419c046283a11c0a21135e8">http://git.php.net/?p=web/master.git;a=commitdiff;h=ab707a8a058e70f93419...</a>

Log:
Paginate note search results instead of showing last 20

Changed paths:
M manage/user-notes.php

Diff:
diff --git a/manage/user-notes.php b/manage/user-notes.php
index 35ea205..01f497a 100644
--- a/manage/user-notes.php
+++ b/manage/user-notes.php
@@ -74,6 +74,18 @@ if (!$action) {
}

if (isset($_REQUEST['keyword']) || isset($_REQUEST["view"])) {
+ // Pagination start
+ $page = isset($_REQUEST["page"]) ?