DevHeads.net

Postings by Sara Golemon

com web/php: Teach mirror-info.php about sha256: mirror-info.php

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=80cd8f4bd74ed6631064ed4f64701b6fff3c1154" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=80cd8f4bd74ed6631064ed4f64701b6fff3c1154">http://git.php.net/?p=web/php.git;a=commitdiff;h=80cd8f4bd74ed6631064ed4...</a>

Log:
Teach mirror-info.php about sha256

MD5 is likely to be deprecated/removed soon,
best to make all the tools ready for that.

Changed paths:
M mirror-info.php

Diff:
diff --git a/mirror-info.php b/mirror-info.php
index 17d9367..0d4e598 100644
--- a/mirror-info.php
+++ b/mirror-info.php
@@ -13,9 +13,19 @@ header("Content-type: text/plain; charset=utf-8");
// Provide information on local stats setup
$mirror_stats = (int) (isset($_SERVER['MIRROR_STATS']) && $_SERVER['MIRROR_STATS'] ==

com web/php: Fix formatting when both md5/sha256 are available: releases/index.php

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=29b6c5f86e6d92d6824b96d45cc85544bdb4774a" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=29b6c5f86e6d92d6824b96d45cc85544bdb4774a">http://git.php.net/?p=web/php.git;a=commitdiff;h=29b6c5f86e6d92d6824b96d...</a>

Log:
Fix formatting when both md5/sha256 are available

This should probably be done more cleanly with CSS,
but this is a quick and dirty good-enough fix.

Changed paths:
M releases/index.php

Diff:
diff --git a/releases/index.php b/releases/index.php
index 271c486..848fbde 100644
--- a/releases/index.php
+++ b/releases/index.php
@@ -183,6 +183,9 @@ function mk_rel($major, $ver, $date, $announcement, $source, $windows, $museum)
download_link($src["filename"], $src["name"]); echo "<br

com web/php: Include SHA256 checksums in /releases/feed.php: releases/feed.php

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=fe9f16cbb3f8bd443d925c799cbb029a888bc836" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=fe9f16cbb3f8bd443d925c799cbb029a888bc836">http://git.php.net/?p=web/php.git;a=commitdiff;h=fe9f16cbb3f8bd443d925c7...</a>

Log:
Include SHA256 checksums in /releases/feed.php

Also guard against release entries with no MD5 entry in the future.

Changed paths:
M releases/feed.php

Diff:
diff --git a/releases/feed.php b/releases/feed.php
index b0d2e96..afdeb58 100644
--- a/releases/feed.php
+++ b/releases/feed.php
@@ -48,9 +48,14 @@ XML;
$maxtime[] = $time = strtotime($source["date"]);
$released = date(DATE_ATOM, $time);

+ echo " <link rel=\"enclosure\" title=\"{$source["name"]

com web/php: Include sha256 checksums on /releases page: releases/index.php

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=da811c575c126d40f7297fadbb759e5b98f68380" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=da811c575c126d40f7297fadbb759e5b98f68380">http://git.php.net/?p=web/php.git;a=commitdiff;h=da811c575c126d40f7297fa...</a>

Log:
Include sha256 checksums on /releases page

Changed paths:
M releases/index.php

Diff:
diff --git a/releases/index.php b/releases/index.php
index 907beac..271c486 100644
--- a/releases/index.php
+++ b/releases/index.php
@@ -184,6 +184,9 @@ function mk_rel($major, $ver, $date, $announcement, $source, $windows, $museum)
if (isset($src["md5"])) {
echo '<span class="md5sum">md5: ' .$src["md5"].

com web/php: Backfill SHA256 checksums for older releases.: include/releases.inc

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=c9224979fe2c56cda84cca664b7eed34df79e16d" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=c9224979fe2c56cda84cca664b7eed34df79e16d">http://git.php.net/?p=web/php.git;a=commitdiff;h=c9224979fe2c56cda84cca6...</a>

Log:
Backfill SHA256 checksums for older releases.

Downloaded each tarball and verified BOTH its GPG signature and MD5 hash.
If BOTH verify cleanly, added a SHA256 entry.

Changed paths:
M include/releases.inc

com web/php: Set pollita@php.net key to expire: include/gpg-keys.inc

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=3b52af0eea466ca2d5a906fa24659f901af0ba8d" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=3b52af0eea466ca2d5a906fa24659f901af0ba8d">http://git.php.net/?p=web/php.git;a=commitdiff;h=3b52af0eea466ca2d5a906f...</a>

Log:
Set <a href="mailto: ... at php dot net"> ... at php dot net</a> key to expire

Changed paths:
M include/gpg-keys.inc

Diff:
diff --git a/include/gpg-keys.inc b/include/gpg-keys.inc
index 9e0a7e6..3d8b295 100644
--- a/include/gpg-keys.inc
+++ b/include/gpg-keys.inc
@@ -6,7 +6,7 @@ $GPG_KEYS = array(
uid Kalle Sommer Nielsen (PHP) &lt; ... at php dot net&gt;
*/
"7.2" => <<< GPG
-pub 4096R/70D12172 2017-04-14
+pub 4096R/70D12172 2017-04-14 [expires: 2024-04-21]
Key fingerprint = 1729 F839 38DA 44E2 7B

com web/php: Encode <> entities in my gpg key (oops): include/gpg-keys.inc

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=80c6514a3249578c4c0a2ce49cfd04881dcc6021" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=80c6514a3249578c4c0a2ce49cfd04881dcc6021">http://git.php.net/?p=web/php.git;a=commitdiff;h=80c6514a3249578c4c0a2ce...</a>

Log:
Encode <> entities in my gpg key (oops)

Changed paths:
M include/gpg-keys.inc

Diff:
diff --git a/include/gpg-keys.inc b/include/gpg-keys.inc
index 82ea486..9e0a7e6 100644
--- a/include/gpg-keys.inc
+++ b/include/gpg-keys.inc
@@ -8,7 +8,7 @@ uid Kalle Sommer Nielsen (PHP) &lt; ... at php dot net&gt;
"7.2" => <<< GPG
pub 4096R/70D12172 2017-04-14
Key fingerprint = 1729 F839 38DA 44E2 7BA0 F4D3 DBDB 3974 70D1 2172
-uid Sara Golemon <pollita@

com web/php: Add pollita@php.net PHP 7.2 GPG key fingerprint: include/gpg-keys.inc

Link: <a href="http://git.php.net/?p=web/php.git;a=commitdiff;h=680accd1381a4d4c8584e91989b8611e7b5123d0" title="http://git.php.net/?p=web/php.git;a=commitdiff;h=680accd1381a4d4c8584e91989b8611e7b5123d0">http://git.php.net/?p=web/php.git;a=commitdiff;h=680accd1381a4d4c8584e91...</a>

Log:
Add <a href="mailto: ... at php dot net"> ... at php dot net</a> PHP 7.2 GPG key fingerprint

Changed paths:
M include/gpg-keys.inc

Diff:
diff --git a/include/gpg-keys.inc b/include/gpg-keys.inc
index d5402e0..82ea486 100644
--- a/include/gpg-keys.inc
+++ b/include/gpg-keys.inc
@@ -5,6 +5,12 @@ $GPG_KEYS = array(
Key fingerprint = D620 173D 6924 BA1C 2244 C7C4 1B6B 6676 22FE 5A12
uid Kalle Sommer Nielsen (PHP) &lt; ... at php dot net&gt;
*/
+ "7.2" => <<< GPG
+pub 4096R/70D12172 2017-04-14
+ Key

com web/bugs: Clearer error message when rejecting comment as potential SPAM: www/bug.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0eaa68643bb16b90cbd3e0f06a487025fd9c0b0b" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0eaa68643bb16b90cbd3e0f06a487025fd9c0b0b">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0eaa68643bb16b90cbd3e0...</a>

Log:
Clearer error message when rejecting comment as potential SPAM

Changed paths:
M www/bug.php

Diff:
diff --git a/www/bug.php b/www/bug.php
index c3635d2..30ee4d4 100644
--- a/www/bug.php
+++ b/www/bug.php
@@ -7,6 +7,8 @@ require_once '../include/prepend.php';
// Start session
session_start();

+define('SPAM_REJECT_MESSAGE', 'Your comment looks like SPAM by its content.

com web/bugs: The selection box will now show the current type of Bug: include/functions.php

Link: <a href="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=21f5fd3484d763be5a53a354d0253a1c8f7b2f2b" title="http://git.php.net/?p=web/bugs.git;a=commitdiff;h=21f5fd3484d763be5a53a354d0253a1c8f7b2f2b">http://git.php.net/?p=web/bugs.git;a=commitdiff;h=21f5fd3484d763be5a53a3...</a>

Log:
The selection box will now show the current type of Bug

Committer's note: I rewrote this from the original PR
at <a href="https://github.com/php/web-bugs/pull/23" title="https://github.com/php/web-bugs/pull/23">https://github.com/php/web-bugs/pull/23</a> for three reasons:
1. The preceeding code usually case folded $current,
but may not depending on the value of $all and $current.
This was likely the source of the original issue being addressed.
By using strcasecmp(), the comparison no longer cares about case.
2.