DevHeads.net

Postings by Michael Heidelbach

There's a stack of diffs...

...waiting to be reviewed.

Hi all!

Please help baloo to (hopefully) improve and have a look at D11753 and
its ancestors.

Thanks in advance,

Michael

baloo needs to be notified of fuse mounts.

Hi!

In order to fix bug 390830 <https://phabricator.kde.org/T8066> (== baloo
should not index plasma-vaults) I need a notification about mounts and
unmounts of fuse.encfs filesystems (and maybe others).

I've tried to find something suitable within Solid - without success so
far. Can you give me some hints, please?

Cheers,

Michael

Would it be good if I became baloo's maintainer?

Hi!

Getting the stuff I do for baloo reviewed takes a lot of time and poking
others. That is considerably slowing me down.

I'm seriously thinking of becoming the maintainer for baloo (and maybe
baloowidgets). Then it would be easier for me to commit those patches I
consider as harmless e.g unit tests. Unless somebody else jumped in I
intended to maintain baloo eventually anyway. I would do it now(!)
mainly for practical reasons. Due to my lack of experience with c++, the
KDE way of using it and the KDE infrastructure in general I'm somewhat
reluctant.

Is it possible to mock an external drive (for unit testing)?

Hi!

Is it? How?

Do examples exist?

Thanks in advance,

Michael

How to improve --help message?

Hi!

Currently balooctl's help looks like this:

$ balooctl  ---help

Usage: balooctl [options] command status enable disable start stop restart suspend resume check index clear config monitor indexSize list

Options:

  -d, --device-id <deviceId>  Restrict to device id.

                              Only applies to "balooctl list"

  -s, --simulate-purge        Simulate purge command.

                

Q_ASSERT(!FalseSecurity)

Hi!

Am I getting something wrong? Or is

"Q_ASSERT(m_writeTrans);

m_writeTrans->commit();"

providing false security?

Shouldn't it better be

"Q_ASSERT(m_writeTrans);

if (m_writeTrans) {

    m_writeTrans->commit(); ?

Baloo's code is full of Q_ASSERTs that have no corresponding if-guard.

To my understanding those would slip through in release-builds. Am I wrong?

Please enlighten me,

Michael

CI fails to build my last commit in a file I did not change

Hi!

Applications baloo-widgets kf5-qt5 FreeBSDQt5.9/
<https://build.kde.org/view/Applications/job/Applications%20baloo-widgets%20kf5-qt5%20FreeBSDQt5.9/>

What to do now?

Cheers,

Michael

Code in peace or How to lint a complete repository?

Hi!

Now that I saw <a href="https://phabricator.kde.org/D10905" title="https://phabricator.kde.org/D10905">https://phabricator.kde.org/D10905</a>, I want to do
something similar for baloo and baloo-widgets.

I'd really like to that once and for all. Because applying coding style
on-the-fly obscures real changes introduced.

1. Would it be reasonable?
2. Who would be willing to review such a huge diff?
3.

Plasma Vault and BUG:390830

Hi!

The best option to fix this bug is by excluding Vaults from being
searched by baloo.

Do that, I need to know how to distinguish vaults from normal folders
(and other mountpoints)

On first glance it appears they are all under ~/Vaults, please confirm.
What about localization?

Cheers,

Michael

Please comment on T8054

It all said, except "Hi!"

... and maybe: C++-wise I'll be entering areas where I've never been before.

... and ...

Cheers,

Michael

Why does kdelibs4support/src/kio/kfilemetadatawidget still exist?

Hi!
Looking at lxr.kde.org
<https://lxr.kde.org/ident?_i=KFileMetaDataWidget> it seems like dolphin
is the only "real" client of KFileMetaDataWidget. Dolphin is not using
it because of
#ifndef HAVE_BALOO
    m_metaDataWidget = new KFileMetaDataWidget(parent);
#else
    m_metaDataWidget = new Baloo::FileMetaDataWidget(parent);
#endif

(How is a clause like the one above called?)
So, what might be the reasons for KFileMetaDataWidget's existence in
kdelibs4support?

Cheers,
Michael

How to temporarily change KConfig-data for a unit test?

Hi!

Currently I'm working on baloo-widgets. For a unit test I need to
temporarily change KConfig data.

My approach would be like this:

initTestCase()

    KConfig config("baloofileinformationrc", KConfig::NoGlobals);
    KConfigGroup settings = config.group("Show");

        set everything to true here.

Revert the changes incleanupTestCase();

How is this done most efficiently and without messing too much with
baloofileinformationrc?

Cheers,

Michael

Baloo is not dead, it just smells a little funny

Hi!

Let me introduce myself first. When I started contributing to KDE with
the beginning of this year this was the status:

* No experience in C++ at all
* Wtr coding: No experience in collaboration and the technologies involved
* No experience in many other things
<https://phabricator.kde.org/T7116#122877>
* Good javascript knowledge
* Hobby developer

since then:

* arcanist hater (that's reciprocal)

That did not keep me from being active: 14 commits this month.

To the point. Baloo:
I think baloo is fantastic!

Is it bad manners to refactor other people's code?

Hi!

Currently I'm working on some code I couldn't understand until I split
some long functions into smaller parts.

As I couldn't find anything about the size-of-a-function topic in the
KDE or Qt guide lines I consider this as a matter of personal taste.

I don't want to step on anybody's toes, so my question is: Should I
submit the refactored code as a review request or - now that I
understand what is going on - weave my changes into the original code?
And what do you think about this in general?

Michael

Dependent review requests

Hi!

When I do

git checkout -b A origin/master

(changes)

git checkout -b B A

(changes)

git checkout A

arc diff

git checkout B

arc diff

Will phabricator show the relation of A and B? Is that a reasonable
approach, anyway?

Michael